Well, I created a PR for this task: https://github.com/apache/servicecomb-toolkit/pull/43 After it's merged, I'll create another PR for merging branch import-oas-validator to master
Bin Ma <mabin1...@gmail.com> 于2019年11月7日周四 上午9:48写道: > > I think it does not affect the existing main process, so it can be merged. > > > Wishes & Regards > ------------------------------- > Mabin > > > > Daniel Qian <chanjars...@gmail.com> 于2019年11月7日周四 上午9:03写道: > > > Hi Ma, what I have done is: > > 1. 3rd-party LICENSE information is merged > > 2. connect the pom.xml together so it can be built from project root dir > > 3. check style functionality he integrated into cli > > So from the perspective of building and distribution, it's been integrated. > > But from the perspective of functionality, it's not finished yet. > > So if we don't care about the functionality, I think it's good to go. > > BTW, merge as early as possible is a good idea to avoid future merge > > conflicts > > > > Bin Ma <mabin1...@gmail.com> 于2019年11月6日周三 下午8:15写道: > > > > > > I found that the integration work has been completed and merged, > > > so I think we can start to merge the import-oas-validator branch to > > > master. > > > > > > Any thoughts? > > > > > > > > > Wishes & Regards > > > ------------------------------- > > > Mabin > > > > > > > > > > > > Daniel Qian <chanjars...@gmail.com> 于2019年11月5日周二 下午1:39写道: > > > > > > > Hi Ma, got it. > > > > > > > > Bin Ma <mabin1...@gmail.com> 于2019年11月5日周二 上午11:19写道: > > > > > > > > > > Hi Daniel, > > > > > > > > > > Sorry, I misread the question. > > > > > > > > > > I think it's better to support both checkcompatibility and cc as > > > > > subcommands. > > > > > > > > > > Wishes & Regards > > > > > ------------------------------- > > > > > Mabin > > > > > > > > > > > > > > > > > > > > sen sun <asd992825...@gmail.com> 于2019年11月5日周二 上午9:40写道: > > > > > > > > > > > I think Ma just made an example of the option naming style instead > > of > > > > the > > > > > > subcommand. > > > > > > I think it's a good idea to support both checkcompatibility and cc > > as > > > > > > subcommands. > > > > > > > > > > > > Daniel Qian <chanjars...@gmail.com> 于2019年11月5日周二 上午7:28写道: > > > > > > > > > > > > > Hello Ma, found current cli style is <subcommand> <options>. > > > > > > > So if we do --check-compatability then which subcommand should we > > > > use? > > > > > > > > > > > > > > Bin Ma <mabin1...@gmail.com> 于2019年11月5日周二 上午12:44写道: > > > > > > > > > > > > > > > > I recommend keeping the same as the current option naming > > style, > > > > > > > > such as "-c", "-- check-compability " > > > > > > > > > > > > > > > > > > > > > > > > Wishes & Regards > > > > > > > > ------------------------------- > > > > > > > > Mabin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Willem Jiang <willem.ji...@gmail.com> 于2019年11月1日周五 下午12:31写道: > > > > > > > > > > > > > > > > > I think we can support checkcompatibility and the short one > > cc > > > > at the > > > > > > > same > > > > > > > > > time. > > > > > > > > > Any thoughts? > > > > > > > > > > > > > > > > > > Willem Jiang > > > > > > > > > > > > > > > > > > Twitter: willemjiang > > > > > > > > > Weibo: 姜宁willem > > > > > > > > > > > > > > > > > > On Wed, Oct 30, 2019 at 10:37 AM Daniel Qian < > > > > chanjars...@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > I created an issue SCB-1555[1] to integrate oas-validator > > > > > > > > > > compatibility check to toolkit cli. > > > > > > > > > > > > > > > > > > > > I suggest usage like this: > > > > > > > > > > java -jar toolkit-cli-{version}.jar checkcompability > > > > > > > > > > /path/to/openapiv3-1.yaml /path/to/openapiv3-2.yaml > > > > > > > > > > > > > > > > > > > > But the subcommand checkcompability is too long, maybe we > > can > > > > use a > > > > > > > > > > abbr for it, such as cc? > > > > > > > > > > > > > > > > > > > > Any ideas? > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/SCB-1555 > > > > > > > > > > [2] > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%85%BC%E5%AE%B9%E6%80%A7%E6%A3%80%E6%9F%A5 > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Daniel Qian > > > > > > > > > > > > > > > > > > > > 博客:https://segmentfault.com/u/chanjarster > > > > > > > > > > github:https://github.com/chanjarster > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Daniel Qian > > > > > > > > > > > > > > 博客:https://segmentfault.com/u/chanjarster > > > > > > > github:https://github.com/chanjarster > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Daniel Qian > > > > > > > > 博客:https://segmentfault.com/u/chanjarster > > > > github:https://github.com/chanjarster > > > > > > > > > > > > -- > > Daniel Qian > > > > blog:https://chanjarster.github.io > > github:https://github.com/chanjarster > > segmentfault: https://segmentfault.com/u/chanjarster > > -- Daniel Qian blog:https://chanjarster.github.io github:https://github.com/chanjarster segmentfault: https://segmentfault.com/u/chanjarster