[ 
https://issues.apache.org/activemq/browse/SMXCOMP-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52138#action_52138
 ] 

Freeman Fang commented on SMXCOMP-531:
--------------------------------------

Hi Jean,
You patch cause a test failure at 
Test set: org.apache.servicemix.eip.MessageFilterSwitchPredicateTest
-------------------------------------------------------------------------------
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.753 sec <<< 
FAILURE!
testPropertyFromFile(org.apache.servicemix.eip.MessageFilterSwitchPredicateTest)
  Time elapsed: 0.012 sec  <<< ERROR!
java.lang.NullPointerException
        at 
org.apache.servicemix.eip.MessageFilterSwitchPredicateTest.testPropertyFromFile(MessageFilterSwitchPredicateTest.java:91)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
I investigate it a little bit, seems your patch miss a file 
switch-off.properties (also switch.properties) which cause the NPE
URL fileUrl = getClass().getResource("switch-off.properties");//so the fileUrl 
is NULL here.
Could you append the missing properties ? And would you please create patch 
against 3.2 branch also?

Thanks
Freeman


> Improve test coverage - ServiceMix :: EIP
> -----------------------------------------
>
>                 Key: SMXCOMP-531
>                 URL: https://issues.apache.org/activemq/browse/SMXCOMP-531
>             Project: ServiceMix Components
>          Issue Type: Test
>          Components: servicemix-eip
>    Affects Versions: servicemix-eip-2009.01
>            Reporter: Chris Custine
>            Assignee: Freeman Fang
>         Attachments: eipUnitTests.patch
>
>
> http://nemo.sonar.codehaus.org/project/index/94778

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to