[ 
https://issues.apache.org/jira/browse/SMX4-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke reopened SMX4-1585:
----------------------------------


Please allow me to reopen this bug and further improve the fix. 
In addition to throwing the IOException we should get rid of the line before 

{code:java}
e.printStackTrace()
{code}

This currently prints the error to stderr (which is the Karaf console). I don't 
see a need for logging the error here as it will already be logged as a warning 
by the NMR and will also get logged by the CXF interceptor with full stack 
traces in each.

{code}
15:27:34,275 | WARN  | qtp832208049-410 | NMR                              | 
265 - org.apache.servicemix.nmr.core - 1.6.0.redhat-60024 | 
Error processing exchange [
  id:        596988866-62354-1381498054120-0-2
  mep:       InOut
  status:    Active
  role:      Consumer
  target:    PropertyMatchingReference[{NAME=someNmrEndpoint, 
INTERFACE_NAME={http://cxf.sample.magicmonster.com}SampleEchoServicePortType}]
  operation: {http://cxf.sample.magicmonster.com}SampleEchoService1
]
org.apache.servicemix.nmr.api.ServiceMixException: Could not dispatch exchange. 
No matching endpoints.
        at 
org.apache.servicemix.nmr.core.FlowRegistryImpl.dispatch(FlowRegistryImpl.java:123)[265:org.apache.servicemix.nmr.core:1.6.0.redhat-60024]
...
15:27:34,280 | WARN  | qtp832208049-410 | PhaseInterceptorChain       
     | 147 - org.apache.cxf.cxf-api - 2.6.0.redhat-60024 | Interceptor for 
{http://cxf.sample.magicmonster.com}SampleEchoService#{http:
//cxf.sample.magicmonster.com}SampleEchoService1 has thrown 
exception, unwinding now
org.apache.cxf.interceptor.Fault: Could not send Message.
at ...
{code}

> org.apache.servicemix.cxf.transport.nmr.NMRConduitOutputStream.commitOutputMessage()
>  does not propagate exception.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SMX4-1585
>                 URL: https://issues.apache.org/jira/browse/SMX4-1585
>             Project: ServiceMix 4
>          Issue Type: Bug
>          Components: cxf-nmr
>         Environment: CXF-NMR transport
>            Reporter: Torsten Mielke
>            Assignee: Freeman Fang
>              Labels: cxf-nmr
>             Fix For: 4.5.3, 4.6.0
>
>         Attachments: SMX4-1585.patch, SMX4-1585.patch
>
>
> There is a bug in 
> {code:title=org.apache.servicemix.cxf.transport.nmr.NMRConduitOutputStream.java
>  }
> private void commitOutputMessage() throws IOException {
>     try {
>     ...
>     } catch (Exception e) {
>         e.printStackTrace();
>         new IOException(e.toString());
>     }
> {code}
> Notice it creates a new IOException but never throws it. As a result the 
> error is ignored completely.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to