jbonofre commented on a change in pull request #145:
URL: https://github.com/apache/servicemix-bundles/pull/145#discussion_r483375272
##########
File path: poi-4.1.2/pom.xml
##########
@@ -88,14 +88,16 @@
org.xml.sax*,
org.w3c.dom*,
javax.xml.*,
+ javax.imageio.*,
Review comment:
I would set this package as optional.
##########
File path: poi-4.1.2/pom.xml
##########
@@ -201,6 +203,18 @@
<version>1.05</version>
<optional>false</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.xmlgraphics</groupId>
Review comment:
No need to add the dependency if it's already a transitive dependency
from POI.
##########
File path: poi-4.1.2/pom.xml
##########
@@ -340,6 +354,12 @@
<exclude>**</exclude>
</excludes>
</filter>
+ <filter>
+
<artifact>org.apache.xmlgraphics:batik-all</artifact>
Review comment:
No needed if it's a transitive dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
