Wendy, I have tested the patch in this way:
I have modified the private method afterRenderResponse of
ViewPhaseListener class:
private void afterRenderResponse(PhaseEvent event) {
// Initialize local values we will need
Map map =
event.getFacesContext().getExternalContext().getRequestMap();
// Remove our list of initialized views explicitly
map.remove(FacesConstants.VIEWS_INITIALIZED);
List list = new ArrayList();
Iterator entries = map.entrySet().iterator();
// First select all the ViewController and AbstractRequestBean
instances
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if ((entry.getValue() instanceof ViewController)
|| (entry.getValue() instanceof AbstractRequestBean)) {
list.add(entry.getKey());
}
}
// Second select all remaining instances, which will include
annotated
// managed beans if Shale Tiger is present
/* COMMENTED BY BUONOPANE
entries = map.entrySet().iterator();
while (entries.hasNext()) {
Map.Entry entry = (Map.Entry) entries.next();
if (!list.contains(entry.getKey())) {
list.add(entry.getKey());
}
}*/
// Iterate through the keys in the specified order, removing the
// corresponding request scope attribute instances
Iterator keys = list.iterator();
while (keys.hasNext()) {
String key = (String) keys.next();
try {
log.info("******** removing "+key);
map.remove(key);
} catch (Exception e) {
handleException(event.getFacesContext(), e);
}
}
}
I have just commented the line of the second loop identified by the
string COMMENTED BY BUONOPANE.
But I don't know if the loop I commented need to be modified.
What do you think?
Regards
Mario
-----Original Message-----
From: Wendy Smoak [mailto:[EMAIL PROTECTED]
Sent: 22 maggio 2007 17.33
To: [EMAIL PROTECTED]
Subject: Re: SHALE-409 fix
On 5/22/07, [EMAIL PROTECTED]
<[EMAIL PROTECTED]> wrote:
> Antonio, I have tested the patch suggested by Matt Hughes at
> http://issues.apache.org/struts/browse/SHALE-409.
Great! First, please come join us on the development list. We
generally keep the user list for discussion about using released
versions. You can find subscription info here, or you can post
through the Nabble forum interface:
http://shale.apache.org/mail-lists.html
What we need is a "svn diff" of your changes against the latest Shale
code. That's the quickest way for the developers to review and apply
changes contributed by the community.
Assuming you have the Shale 1.0.x branch checked out and have made
changes to it locally, execute "svn diff > SHALE-409.patch" and attach
the patch file to the issue.
Thanks,
--
Wendy
This message is for the designated recipient only and may contain privileged,
proprietary, or otherwise private information. If you have received it in
error, please notify the sender immediately and delete the original. Any other
use of the email by you is prohibited.
