terrymanu commented on a change in pull request #1807: for sql revert
URL:
https://github.com/apache/incubator-shardingsphere/pull/1807#discussion_r250453679
##########
File path:
sharding-core/src/main/java/org/apache/shardingsphere/core/parsing/antlr/filler/impl/OrConditionFiller.java
##########
@@ -210,23 +210,22 @@ private String getTableName(final ShardingRule
shardingRule, final Tables tables
return table.isPresent() ? table.get().getName() : "";
}
- /**
- * build equals condition.
- *
- * @param column column
- * @param expressionSegment SQL segment
- * @param sql SQL
- * @return Condition
- */
- public Optional<Condition> buildEqualsCondition(final Column column, final
ExpressionSegment expressionSegment, final String sql) {
+ private Optional<Condition> buildEqualsCondition(final Column column,
final ExpressionSegment expressionSegment, final String sql) {
Optional<SQLExpression> expression =
buildExpression(expressionSegment, sql);
if (expression.isPresent()) {
return Optional.of(new Condition(column, expression.get()));
}
return Optional.absent();
}
- private Optional<SQLExpression> buildExpression(final ExpressionSegment
expressionSegment, final String sql) {
+ /**
+ * build expression.
+ *
+ * @param expressionSegment SQL segment
Review comment:
javadoc and @param should match
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
