terrymanu commented on issue #1844: Sharding Encryptor URL: https://github.com/apache/incubator-shardingsphere/issues/1844#issuecomment-462284236 We need to consider about interface of `ShardingEncryptor`. Right now is: ```java Object encrypt(Object plaintext); Object decrypt(Object ciphertext); ``` The parameter for `encrypt` is `plaintext`, and return value is object, `plaintext` means the parameter is String. so, maybe should rename param name as plainValue, and return value will save into database, object is more useless, string is a good return type. The parameter for `decrypt` is `ciphertext`, it is returned by database, so string is good type. object of return type is fine.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
