Looks good to me. Sion Yang <[email protected]> 于2019年10月17日周四 上午8:56写道：
> It's sounds great. > > > > > -- > > Yi Yang(Sion) > Apache ShardingSphere > > > > At 2019-10-16 21:51:32, "董。" <[email protected]> wrote: > >Hi ALL: > > > > We discuss a code implementation about a issue and a PR. > > > > > > the issue is: > https://github.com/apache/incubator-shardingsphere/issues/3231 > > > > > > the PR is: > https://github.com/apache/incubator-shardingsphere/pull/3288 > > > > > > We discuss the relationship between Database numeric (int & bigint) > column type and Java DataType. > > > > > > If Database column type is INT, we can use JDBC's ResultSet#getInt() > method, get the column data. > > > > > > But if the column type is UNSIGNED INT, the value maybe beyond Java's > Integer value range, so we shoudld use JDBC's ResultSet#getLong() method to > get the column data. > > > > > > So the result of discussion is: > > > > > > If column type is TINYINT & SMALLINT & SIGNED INT, we use JDBC's > ResultSet#getInt() method to get column data; > > If column type is UNSIGNED INT, we use JDBC's ResultSet#getLong() > method to get column data; > > If column type is SIGNED BIGINT, we use JDBC's ResultSet#getLong() > method to get column data; > > If column type is UNSIGNED BIGINT, we use JDBC's > ResultSet#getBigDemical() method to get column data and return BigInteger > Object. > -- Zhang Yonglun Apache ShardingSphere
