Hi Sheng,
Thanks for your sound advices. I will review the problems you mentioned. Juan Pan [email protected] Juan Pan(Trista), Apache ShardingSphere On 10/31/2019 19:17, Sheng Wu wrote: One addition question, Why our changelog[1] so simple? The answer must be NO, and big NO. From the GitHub release page[2], 499 commit difference between current and last release, but get just 5 lines of the update? I think that is not the purpose of the release changelog. [1] https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md [2] https://github.com/apache/incubator-shardingsphere/releases Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108 Sheng Wu <[email protected]> 于2019年10月31日周四 下午4:41写道： > Pan Juan > > -1 (binding from PPMC or IPMC perspective) > > Sorry to say so. > > You are shipping all UI dependency in the src tar. Is this really > necessary? And if so, what is the meaning of source release of UI? > Do you notice, your source tar is nearly 200M? It is mostly caused by UI > frontend. > Another one, why all releases are not signed by your Apache mail? > > Sheng Wu 吴晟 > > Apache SkyWalking > Apache Incubator > Apache ShardingSphere, ECharts, DolphinScheduler podlings > Zipkin > Twitter, wusheng1108 > > > Juan Pan <[email protected]> 于2019年10月31日周四 上午7:56写道： > >> >> >> Hello ShardingSphere Community, >> >> >> This is a call for vote to release Apache ShardingSphere (Incubating) >> version 4.0.0-RC3 >> >> >> Release notes: >> >> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md >> >> >> The release candidates: >> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/ >> >> >> Maven 2 staging repository: >> >> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1023/org/apache/shardingsphere/ >> >> >> Git tag for the release: >> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/ >> >> >> Release Commit ID: >> >> https://github.com/apache/incubator-shardingsphere/commit/6885dcfc281eec7691636875e298287a0147f176 >> >> >> Keys to verify the Release Candidate: >> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS >> >> >> Look at here for how to verify this release candidate: >> https://shardingsphere.apache.org/community/en/contribute/release/ >> >> >> The vote will be open for at least 72 hours or until necessary number of >> votes are reached. >> >> >> Please vote accordingly: >> >> >> [ ] +1 approve >> >> >> [ ] +0 no opinion >> >> [ ] -1 disapprove with the reason >> >> >> Checklist for reference: >> >> >> [ ] Download links are valid. >> >> >> [ ] Checksums and PGP signatures are valid. >> >> >> [ ] DISCLAIMER is included. >> >> >> [ ] Source code artifacts have correct names matching the current release. >> >> >> [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo. >> >> >> [ ] All files have license headers if necessary. >> >> >> [ ] No compiled archives bundled in source archive. >> >> >> Best wishes, >> Trista >> >> >> Juan Pan >> >> >> [email protected] >> Juan Pan(Trista), Apache ShardingSphere >> >>
