I have installed the source code and a unit test failed:
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running
org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.48 s <<< FAILURE! - in
org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest
[ERROR]
assertInitDataSource(org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest)
Time elapsed: 0.329 s <<< FAILURE!
java.lang.AssertionError
at
org.apache.shardingsphere.route.time.mysql.MySQLTimeServiceTest.assertInitDataSource(MySQLTimeServiceTest.java:48)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] MySQLTimeServiceTest.assertInitDataSource:48
The root cause is the inputStream is not close then leading to a file close
failure.
The source code: 55th line of MySQLTimeService.java
linzesi <[email protected]> 于2019年11月8日周五 上午10:32写道：
>
>
> +1.
>
>
> checked list:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
> On 11/8/2019 10:24，董。<[email protected]> wrote：
> +1.
>
>
> checked list:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
>
>
>
> Best wishes.
>
>
> ------------------ 原始邮件 ------------------
> 发件人: "Sion Yang"<[email protected]>;
> 发送时间: 2019年11月8日(星期五) 上午9:21
> 收件人: "dev"<[email protected]>;
>
> 主题: Re:Re: [VOTE] Release Apache ShardingSphere (Incubating)
> 4.0.0-RC3 ROUND 3
>
>
>
> +1.
>
> I checked:
>
> [X] Download links are valid.
> [X] Checksums and PGP signatures are valid.
> [X] DISCLAIMER is included.
> [X] Source code artifacts have correct names matching the current release.
> [X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> [X] All files have license headers if necessary.
> [X] No compiled archives bundled in source archive.
>
>
>
>
> --
>
> Yi Yang(Sion)
> Apache ShardingSphere
>
>
>
> At 2019-11-07 20:23:18, "[email protected]" <[email protected]>
> wrote:
> >+1.
> >
> >I checked:
> >
> >[X] Download links are valid.
> >[X] Checksums and PGP signatures are valid.
> >[X] DISCLAIMER is included.
> >[X] Source code artifacts have correct names matching the current
> release.
> >[X] LICENSE and NOTICE files are correct for each ShardingSphere repo.
> >[X] All files have license headers if necessary.
> >[X] No compiled archives bundled in source archive.
> >
> >------------------
> >
> >Liang Zhang (John)
> >Apache ShardingSphere & Dubbo
> >
> >
> >Juan Pan <[email protected]> 于2019年11月7日周四 下午7:34写道：
> >
> >> Hi ShardingSphere Community,
> >>
> >>
> >> I tried my best to solve the issues you raised, and went through
> the check
> >> list twice to avoid the confusion, but your review and vote on
> this release
> >> is important to us. Look forward to your attention and
> interaction.
> >>
> >>
> >> Release notes:
> >>
> >>
> https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md
> >>
> <https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md>>>
> ;
> >>
> >> The release candidates:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/
> >>
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/>>>
> ;
> >>
> >> Maven 2 staging repository:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapacheshardingsphere-1026/org/apache/shardingsphere/
> >>
> <https://repository.apache.org/content/repositories/orgapacheshardingsphere-1026/org/apache/shardingsphere/>>>
> ;
> >>
> >> Git tag for the release:
> >>
> https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/
> >>
> <https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/>>>
> ;
> >>
> >> Release Commit ID:
> >>
> >>
> https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693bde04b7e0742386fdcb94b93bd60
> >>
> <https://github.com/apache/incubator-shardingsphere/commit/ea05bb0ff693bde04b7e0742386fdcb94b93bd60>>>
> ;
> >>
> >> Keys to verify the Release Candidate:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS
> >>
> <https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS>>>
> ;
> >>
> >> Look at here for how to verify this release candidate:
> >>
> https://shardingsphere.apache.org/community/en/contribute/release/
> >>
> <https://shardingsphere.apache.org/community/en/contribute/release/>>>
> ;
> >>
> >> The vote will be open for at least 72 hours or until necessary
> number of
> >> votes are reached.
> >>
> >>
> >> Please vote accordingly:
> >>
> >>
> >> [ ] +1 approve
> >>
> >>
> >> [ ] +0 no opinion
> >>
> >> [ ] -1 disapprove with the reason
> >>
> >>
> >> Checklist for reference:
> >>
> >>
> >> [ ] Download links are valid.
> >>
> >>
> >> [ ] Checksums and PGP signatures are valid.
> >>
> >>
> >> [ ] DISCLAIMER is included.
> >>
> >>
> >> [ ] Source code artifacts have correct names matching the current
> release.
> >>
> >>
> >> [ ] LICENSE and NOTICE files are correct for each ShardingSphere
> repo.
> >>
> >>
> >> [ ] All files have license headers if necessary.
> >>
> >>
> >> [ ] No compiled archives bundled in source archive.
> >>
> >>
> >>
> >>
> >> Best wishes,
> >> Trista
> >>
> >>
> >> Juan Pan
> >>
> >>
> >> [email protected]
> >> Juan Pan(Trista), Apache ShardingSphere
> >>
> >>
--
Zhang Yonglun
Apache ShardingSphere
