I guess so, but my point is, you didn't mention it in changelog file. >From my understanding, all information should be hosted in ASF INFRA, which excludes the GitHub milestone list as an optional one. And most important is, a milestone could be changed after your release.
Sheng Wu 吴晟 Apache SkyWalking Apache Incubator Apache ShardingSphere, ECharts, DolphinScheduler podlings Zipkin Twitter, wusheng1108 [email protected] <[email protected]> 于2019年11月13日周三 上午11:39写道： > The release notes has all change logs in milestone[1] which in the end of > each release version, because change logs in milestone is too big, so we > just summary some important issues. > > [1] https://github.com/apache/incubator-shardingsphere/milestone/8 > ------------------ > > Liang Zhang (John) > Apache ShardingSphere & Dubbo > > > Sheng Wu <[email protected]> 于2019年11月13日周三 上午9:19写道： > > > +1 > > > > The issues mentioned before have been fixed. > > > > asc sign checked and based on apache mail. > > NOTICE, LICENSE, and DISCLAIMER exist. > > sha512 is there > > compiling works > > > > A tiny issue, > > The changelog seems to ignore many fixes and code changes. > > Such as bugfix #3401[1] never shows up in a changelog. > > The principle of changelog contents seems not clear to me. > > This is not a release block, but I feel it should be discussed. > > > > [1] https://github.com/apache/incubator-shardingsphere/pull/3401 > > > > > > Sheng Wu 吴晟 > > > > Apache SkyWalking > > Apache Incubator > > Apache ShardingSphere, ECharts, DolphinScheduler podlings > > Zipkin > > Twitter, wusheng1108 > > > > > > Juan Pan <[email protected]> 于2019年11月11日周一 下午6:40写道： > > > > > Hi everyone, > > > > > > > > > With the help and effort of our community, the previous issues were > fixed > > > already. I am glad to invite everyone to move on to check and vote for > > our > > > 4.0.0-RC3 ROUND 4. > > > > > > > > > Release notes: > > > > > > > > > https://github.com/apache/incubator-shardingsphere/blob/dev/RELEASE-NOTES.md > > > > > > > > > The release candidates: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/4.0.0-RC3/ > > > > > > > > > Maven 2 staging repository: > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheshardingsphere-1027/org/apache/shardingsphere/ > > > > > > > > > Git tag for the release: > > > https://github.com/apache/incubator-shardingsphere/tree/4.0.0-RC3/ > > > > > > > > > Release Commit ID: > > > > > > > > > https://github.com/apache/incubator-shardingsphere/commit/78a67e8c088ffc0b6f0e2c7418b0217cdc3bb87d > > > > > > > > > Keys to verify the Release Candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/shardingsphere/KEYS > > > > > > > > > Look at here for how to verify this release candidate: > > > https://shardingsphere.apache.org/community/en/contribute/release/ > > > > > > > > > The vote will be open for at least 72 hours or until necessary number > of > > > votes are reached. > > > > > > > > > Please vote accordingly: > > > > > > > > > [ ] +1 approve > > > > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > Checklist for reference: > > > > > > > > > [ ] Download links are valid. > > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > > [ ] DISCLAIMER is included. > > > > > > > > > [ ] Source code artifacts have correct names matching the current > > release. > > > > > > > > > [ ] LICENSE and NOTICE files are correct for each ShardingSphere repo. > > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > > [ ] No compiled archives bundled in source archive. > > > > > > > > > > > > > > > Best wishes, > > > Trista > > > > > > > > > Juan Pan > > > > > > > > > [email protected] > > > Juan Pan(Trista), Apache ShardingSphere > > > > > > > > >
