All issues are fine now. We are not plan to release a perfect version, but just release a basic available version, and we can release 4.0.1, 4.0.2 ... continuously.
I will prepare to release version 4.0.0 soon. Thank you. ------------------ Liang Zhang (John) Apache ShardingSphere & Dubbo Zhang Yonglun <[email protected]> 于2019年12月13日周五 上午11:04写道： > This is a LOCAL Transaction scenario, maybe @ > <https://github.com/cherrylzhao>zhaojun could help. > > linzesi <[email protected]> 于2019年12月13日周五 上午6:01写道： > > > sharding-proxy query different results of data when > > 'max.connections.size.per.query' is diffetent for server.yaml > > > > Sharding-Proxy Version: dev > > > > mysql-version: 5.7 > > java-version:jdk8 > > OS: window10 > > > > I've set up this issue#3732( > > https://github.com/apache/incubator-shardingsphere/issues/3732) > > > > configuration: > > config-sharding.yaml > > > > schemaName: sharding_db > > > > dataSources: > > ds_0: > > url: jdbc:mysql:// > > 127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false > > username: root > > password: > > connectionTimeoutMilliseconds: 30000 > > idleTimeoutMilliseconds: 60000 > > maxLifetimeMilliseconds: 1800000 > > maxPoolSize: 50 > > ds_1: > > url: jdbc:mysql:// > > 127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false > > username: root > > password: > > connectionTimeoutMilliseconds: 30000 > > idleTimeoutMilliseconds: 60000 > > maxLifetimeMilliseconds: 1800000 > > maxPoolSize: 50 > > > > shardingRule: > > tables: > > t_order: > > actualDataNodes: ds_${0..1}.t_order_${0..1} > > tableStrategy: > > inline: > > shardingColumn: order_id > > algorithmExpression: t_order_${order_id % 2} > > keyGenerator: > > type: SNOWFLAKE > > column: order_id > > t_order_item: > > actualDataNodes: ds_${0..1}.t_order_item_${0..1} > > tableStrategy: > > inline: > > shardingColumn: order_id > > algorithmExpression: t_order_item_${order_id % 2} > > keyGenerator: > > type: SNOWFLAKE > > column: order_item_id > > bindingTables: > > - t_order,t_order_item > > broadcastTables: > > - t_address > > defaultDatabaseStrategy: > > inline: > > shardingColumn: user_id > > algorithmExpression: ds_${user_id % 2} > > defaultTableStrategy: > > none: > > > > > > > > server.yaml > > when max.connections.size.per.query=1 > > > > authentication: > > users: > > root: > > password: > > sharding: > > password: sharding > > authorizedSchemas: sharding_db > > > > props: > > max.connections.size.per.query: 1 > > acceptor.size: 16 # The default value is available processors count * > 2. > > executor.size: 16 # Infinite by default. > > proxy.frontend.flush.threshold: 128 # The default value is 128. > > # LOCAL: Proxy will run with LOCAL transaction. > > # XA: Proxy will run with XA transaction. > > # BASE: Proxy will run with B.A.S.E transaction. > > proxy.transaction.type: LOCAL > > proxy.opentracing.enabled: false > > query.with.cipher.column: true > > sql.show: false > > > > > > > > print result： > > > > ---------------------------- Print Order Data ----------------------- > > order_id: 412075829204353025, user_id: 2, address_id: 2, status: > > INSERT_TEST > > order_id: 412075829279850497, user_id: 4, address_id: 4, status: > > INSERT_TEST > > order_id: 412075829330182145, user_id: 6, address_id: 6, status: > > INSERT_TEST > > order_id: 412075829384708097, user_id: 8, address_id: 8, status: > > INSERT_TEST > > order_id: 412075829439234049, user_id: 10, address_id: 10, status: > > INSERT_TEST > > order_id: 412075829162409984, user_id: 1, address_id: 1, status: > > INSERT_TEST > > order_id: 412075829246296064, user_id: 3, address_id: 3, status: > > INSERT_TEST > > order_id: 412075829300822016, user_id: 5, address_id: 5, status: > > INSERT_TEST > > order_id: 412075829359542272, user_id: 7, address_id: 7, status: > > INSERT_TEST > > order_id: 412075829414068224, user_id: 9, address_id: 9, status: > > INSERT_TEST > > > > > > when max.connections.size.per.query>1,such as: > > max.connections.size.per.query:2 (The others configuration are the same) > > > > print result： > > > > ---------------------------- Print Order Data ----------------------- > > order_id: 412072322820734976, user_id: 1, address_id: 1, status: > > INSERT_TEST > > order_id: 412072323223388160, user_id: 3, address_id: 3, status: > > INSERT_TEST > > order_id: 412072323273719808, user_id: 5, address_id: 5, status: > > INSERT_TEST > > order_id: 412072323319857152, user_id: 7, address_id: 7, status: > > INSERT_TEST > > order_id: 412072323365994496, user_id: 9, address_id: 9, status: > > INSERT_TEST > > > > > > Run Example: > > click > > > > On 12/12/2019 17:57，[email protected]<[email protected]> wrote： > > Thank you for find bugs. we need to repair this issue before release. > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > linzesi <[email protected]> 于2019年12月12日周四 下午5:21写道： > > > > When I write shardingsphere-acceptance-test cases. I find a problem as > > follow: > > sharding-proxy cannot query data when 'max.connections.size.per.query=1' > > for server.yaml using springboot and mybatis framework. > > > > > > sharding-proxy version: dev > > mysql-version: 5.7 > > java-version:jdk8 > > OS: window10 > > > > > > I've set up this issue#3725( > > https://github.com/apache/incubator-shardingsphere/issues/3725) > > configuration： > > config-sharding.yaml > > schemaName: sharding_db > > > > dataSources: > > ds_0: > > url: jdbc:mysql:// > 127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false > > username: root > > password: > > connectionTimeoutMilliseconds: 30000 > > idleTimeoutMilliseconds: 60000 > > maxLifetimeMilliseconds: 1800000 > > maxPoolSize: 50 > > ds_1: > > url: jdbc:mysql:// > 127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false > > username: root > > password: > > connectionTimeoutMilliseconds: 30000 > > idleTimeoutMilliseconds: 60000 > > maxLifetimeMilliseconds: 1800000 > > maxPoolSize: 50 > > > > shardingRule: > > tables: > > t_order: > > actualDataNodes: ds_${0..1}.t_order_${0..1} > > tableStrategy: > > inline: > > shardingColumn: order_id > > algorithmExpression: t_order_${order_id % 2} > > keyGenerator: > > type: SNOWFLAKE > > column: order_id > > t_order_item: > > actualDataNodes: ds_${0..1}.t_order_item_${0..1} > > tableStrategy: > > inline: > > shardingColumn: order_id > > algorithmExpression: t_order_item_${order_id % 2} > > keyGenerator: > > type: SNOWFLAKE > > column: order_item_id > > bindingTables: > > - t_order,t_order_item > > broadcastTables: > > - t_address > > defaultDatabaseStrategy: > > inline: > > shardingColumn: user_id > > algorithmExpression: ds_${user_id % 2} > > defaultTableStrategy: > > none: > > server.yaml > > authentication: > > users: > > root: > > password: root > > sharding: > > password: sharding > > authorizedSchemas: sharding_db > > > > props: > > max.connections.size.per.query: 1 > > acceptor.size: 16 # The default value is available processors count * 2. > > executor.size: 16 # Infinite by default. > > proxy.frontend.flush.threshold: 128 # The default value is 128. > > # LOCAL: Proxy will run with LOCAL transaction. > > # XA: Proxy will run with XA transaction. > > # BASE: Proxy will run with B.A.S.E transaction. > > proxy.transaction.type: LOCAL > > proxy.opentracing.enabled: false > > query.with.cipher.column: true > > sql.show: false > > > > > > Running example( > > > > > https://github.com/apache/incubator-shardingsphere-example/blob/dev/sharding-proxy-example/sharding-proxy-boot-mybatis-example/src/main/java/org/apache/shardingsphere/example/proxy/spring/boot/mybatis/SpringBootStarterExample.java > > ) > > > > > > > > > > > > > > > > > > > > > > On 12/9/2019 11:45，Zhang Yonglun<[email protected]> wrote： > > Liang, > > > > You are right. I'll create a schedule for performance test. > > > > > > Zhang Yonglun > > Apache ShardingSphere > > > > > > [email protected] <[email protected]> 于2019年12月9日周一 上午11:34写道： > > > > Acceptance test framework will be established soon. > > The proposal is to assert the project is OK basically. we don't expect > it > > can assert all function details. > > We prefer using uint tests and integrated test engine to assert all > > function details, it is fine now. > > > > So, IMO, we can establish the acceptance test framework asynchronically. > > We just waiting the first result of performance test to decide whether we > > can release now. > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > zhaojun <[email protected]> 于2019年12月9日周一 上午11:10写道： > > > > It looks good to me, but it’s better we have a mechanism to verify > > whether > > 4.0.0 is stable or not. > > > > ------------------ > > Zhao Jun (cherrylzhao) > > Apache Sharding-Sphere & ServiceComb > > > > On Dec 9, 2019, at 10:53 AM, Sheng Wu <[email protected]> > > wrote: > > > > zhaojun <[email protected]> 于2019年12月9日周一 上午10:21写道： > > > > @Sheng > > > > Maybe you have misunderstood what i have said. > > I meant if we have not an acceptance-test framework, maybe we will > > spend > > another several months to process release work. > > This is a critical problems we should face with. > > > > > > No very critical I think :) > > Agree that, it is important and ease the PPMC/committer team concerns > > when > > doing the release. > > > > For 4.0.0, I think we should be ready to go. We are as same as all > > other > > libraries, could send 4.0.1, 4.0.2, if we are really facing serious > > bug. > > My point it only, let's finish no stable version status of ss, it has > > last > > one year, it is not good for users. > > > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > > > ------------------ > > Zhao Jun (cherrylzhao) > > Apache Sharding-Sphere & ServiceComb > > > > On Dec 8, 2019, at 10:50 PM, Sheng Wu <[email protected]> > > wrote: > > > > zhaojun <[email protected]> 于2019年12月8日周日 下午9:50写道： > > > > Acceptance-test framework will make release workflow more smoothly. > > We will spend a lot of time (maybe months) to verify the function > > manually > > on every release time. > > > > > > Several months? Are you saying ShardingSphere will have no stable > > release > > in over 1.5 years? > > Are PPMC serious sure about this? > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > > > In fact, we could not release a version ASAP now. > > > > ------------------ > > Zhao Jun (cherrylzhao) > > Apache ShardingSphere & ServiceComb > > > > On Dec 7, 2019, at 6:54 PM, Sheng Wu <[email protected]> > > wrote: > > > > Make sense to me. > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > [email protected] <[email protected]> 于2019年12月7日周六 > > 下午6:47写道： > > > > How about get the result of performance test at last? It is a good > > way > > to > > confirm there are no performance issue for the stable version. > > It should be ok soon, maybe next week. We can list a scheduler for > > the > > detail of performance test. > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > Juan Pan <[email protected]> 于2019年12月7日周六 下午6:09写道： > > > > Hi Sheng, > > > > > > Thanks for your clarification, i get your point. > > > > > > Juan Pan > > > > > > [email protected] > > Juan Pan(T-rista), Apache ShardingSphere > > > > > > On 12/7/2019 17:59，Sheng Wu<[email protected]> wrote： > > Hi > > > > Actually, my point is those two even not source release :) Those > > are > > test > > frameworks. The user would feel they exist. > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > Juan Pan <[email protected]> 于2019年12月7日周六 下午5:50写道： > > > > Hi Sheng and Liang, > > > > > > I totally agree to release a stable version for community ASAP, > > however i > > am curious about the release note and the intending date of it. > > Is > > there > > any new for this release, or just hot bugfix? As Sheng said, > > ISSUE[1] > > and > > [2] seems not block, so Liang, would you like to include them > > into > > this > > release? What’s the estimated time of completion? > > > > > > Thanks, > > > > > > Trista > > > > > > > > > > Juan Pan > > > > > > [email protected] > > Juan Pan(Trista), Apache ShardingSphere > > > > > > On 12/7/2019 17:23，Sheng Wu<[email protected]> wrote： > > [email protected] <[email protected]> 于2019年12月7日周六 > > 下午5:18写道： > > > > Hi, ShardingSphere community, > > > > I'd like to talk about the release plan of 4.0.0 stable version. > > As you know, after enter Apache incubator, ShardingSphere had > > released > > 3 > > RC > > versions during the past year. The features are stable more and > > more, > > it > > is > > the time to talk about task details before 4.0.0 release. > > > > I just list some tasks that I knew, please add if I missing > > something: > > > > 1. Performance test display. The current result is in [1], we > > still > > need > > to > > do some adjust to make it better. > > 2. Acceptance test. The repo is in [2], we still need docker and > > shell > > to > > make it run automatically. And we will transfer it to apache > > repo[3] > > soon. > > > > > > I think these two are not blocks for the stable release. :) > > > > > > 3. Remain bugs hot fix. I don't find any high priority bug to be > > fixed > > now. > > > > > > If no high priority bug, I think this is a good time to do the > > official > > release now. > > ShardingSphere has no stable release in the whole of 2019. We > > should > > do > > this ASAP. > > > > What do other PPMC think? > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > > > > > Any other tasks missing here? > > > > [1] https://shardingsphere.apache.org/benchmark/#/overview > > [2] > > https://github.com/OpenSharding/shardingsphere-acceptance-test > > [3] > > https://github.com/apache/incubator-shardingsphere-acceptance-test > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Zhang Yonglun > Apache ShardingSphere >
