Awesome. According to the decouple principle about abstraction and implementation, unit tests maybe need to cover two parts: config api and specified implements.
At 2020-02-10 18:41:45, "Haoran Meng" <[email protected]> wrote: >Orchestration5.x branch is a good foundation for the HA plan. >In order to make this more robust, we plan to reorganize the unit tests of >this module and continue to improve in subsequent versions. >Now I am doing this. > >KimmKing <[email protected]> 于2020年2月10日周一 下午5:13写道： > >> Hi, Community: >> Based on three community >> committers(wangguangyuan/sunbufu/dongzonglei) wonderful contribution, >> configuration center and registry center have separated into two >> independent concepts now in apache/orchestration5.x branch. >> The main modification is that redesign two interfaces ConfigCenter >> and RegistryCenter, they encapsulating abstract get/put data operations for >> that anyone can implement your own center with your own frameworks, and >> value-change events make sure config values modified by other nodes or UI >> console can make immediate effect. >> As an obvious result, we should explicitly configure a group >> parameters as a 'config-center' or 'registry-center' in server.yaml file. >> So, several new parameters added such as: >> ``` >> orchestrationType: config_center,registry_center, >> instanceType: zookeeper, >> ``` >> And then origin registry node is removed, its sub-parameters those >> describe certain framework config like zookeeper directly become the >> children of orchestration node. >> A typical server.yaml config file like: >> ``` >> orchestration: >> name: orchestration_ds >> overwrite: true >> registry: >> type: zookeeper >> serverLists: localhost:2181 >> namespace: orchestration >> ``` >> But now it will be like: >> ``` >> orchestration: >> orchestration_ds: >> orchestrationType: config_center,registry_center >> instanceType: zookeeper >> serverLists: localhost:2181 >> namespace: orchestration >> props: >> overwrite: true >> ``` >> >> >> We still can modify all config parameters by UI console, and we will >> improve UI console to support configuring config-center and registry-center >> independently as soon as later. >> >> >> Haoran Meng and I will join the community in and focus on orchestration >> related issues with the awesome partners -- wangguangyuan，sunbufu and >> dongzonglei. We will follow the orchestration plan in Haoran's letter >> talking about this topic and keep moving on, Agile and Faster. >> >> >> It's a big picture, we need more buddies join in and give more ideas and >> suggestions. We could have a discussion here now. >> Thanks a lot. >> >> >> >> >> -- >> Kimm King([email protected]/[email protected]) >> >>
