+1, I found another mysql8 compatible issue[1], it's better to release it in 4.1.1.
since theMySQLServerInfo.SERVER_VERSION is fixed at 5.6.4, so jdbc-driver will send the sql contains query_cache_size, we should dynamically judge it based on the physical database version, also i'have made some enhancement advices. [1]: https://github.com/apache/shardingsphere/issues/3097 Regards, cherrylzhao ------------------------------------------------------- Email：[email protected] Jun Zhao(cherrylzhao) Apache ShardingSphere Zhiyi Yan <[email protected]> 于2020年5月14日周四 下午6:02写道： > Good idea. > > ---------------- > Zhiyi Yan (Zhyee) > Apache ShardingSphere > > > [email protected] <[email protected]> 于2020年5月14日周四 下午5:55写道： > > > +1, release 4.1.1 is necessary and we at least need to include #5436 > which > > is break all Oracle dialect. > > > > IMO, release this one issue only is good enough. > > > > ------------------ > > > > Liang Zhang (John) > > Apache ShardingSphere & Dubbo > > > > > > TaoZhi <[email protected]> 于2020年5月14日周四 下午4:16写道： > > > > > In my opnion, the releasing of the version 4.1.1 is better. > > > > > > > > > > > > > > > TaoZhi > > > > > > At 2020-05-14 14:46:23, "KimmKing" <[email protected]> wrote: > > > >Hi, community. > > > > After the latest version 4.1.0 release, there is a bug[1] found > > > during loading Oracle tables metadata and cause sharding-jdbc/proxy > can't > > > bootstrap. > > > > And it had fixed in master by a community contributor now [2]. > > > > So, we should consider about a hotfix release version 4.1.1, fix > > it > > > to backport 4.x, and make sure Oracle env users can be use this coming > > > version. > > > > > > > > > > > > Any suggestion/idea is welcome. > > > > > > > > > > > >[1].https://github.com/apache/shardingsphere/issues/5581 > > > >[2].https://github.com/apache/shardingsphere/pull/5436 > > > > > > > > > >
