I prefer use prefix 'shardingsphere', it looks more complete and clear.

----------------------
Zhiyi Yan (Zhyee)
Apache ShardingSphere


KimmKing <[email protected]> 于2020年5月15日周五 下午1:28写道:

> Haoran & Xiaoyu:
>
>
> There is one thing shoule be clarified: Whose Prefix.
> The word Prefix has three meanings:
> 1. directory name in repo root dir
> 2. sub module name in pom file and maven artifactId field
> 3. binary jar file name and related release tar.gz file name
>
>
> So, we should point which one is the Actual Meaning exactly in your post.
>
>
> For the point 1, prefix is not an important issue.
> For the point 2, the prefix is already in groupId, such as
> org.apache.shardingsphere, and the whole maven coordinate is like
> org.apache.shardingsphere:orchestration-center-etcd:5.0.0. As you know, if
> we add another prefix in modue name, it will be
> org.apache.shardingsphere:shardingsphere-orchestration-center-etcd:5.0.0.
> There is one more duplicated shardingsphere word.
> For the point 3, jar file name is usually the same with module name and
> version, and the assemebly tar.gz file should have a shardingsphere prefix
> to show the owner, such as apache-shardingsphere-proxy-5.0.0-bin.tag.gz.
>
> 在 2020-05-15 12:48:02,"Myth" <[email protected]> 写道:
> >I prefer hold the prefix&nbsp; `shardingsphere`,&nbsp;
> >becaues&nbsp;
> >&nbsp; 1. the uniform prefix feels neat .
> >&nbsp; 2. make people understand the ownership and mean of the module
> more.
> >module names that are too long should not be a concern, and it not long
> >
> >
> >thanks.
> >
> >
> >
> >
> >------------------&nbsp;原始邮件&nbsp;------------------
> >发件人:&nbsp;"Haoran Meng"<[email protected]&gt;;
> >发送时间:&nbsp;2020年5月15日(星期五) 中午12:36
> >收件人:&nbsp;"dev"<[email protected]&gt;;
> >
> >主题:&nbsp;Re: Aggregate and redesign modules for ShardingSphere 5.x
> >
> >
> >
> >Hi, Liang
> >
> >
> >Point 1 :
> >
> >I prefer hold the prefix&nbsp; `shardingsphere`,&nbsp; if some moudles
> name with `
> >shardingsphere` prefix&nbsp; are too long , i suggest&nbsp; may be we can
> consider
> >optimizing the module name first.
> >
> >I think without prefix is simpler, but with prefix is more tidy.
> >
> >Point 2 :
> >
> >&nbsp;`scaling`&nbsp; is independent ,but it doesn't look like the same
> level as
> >others.
> >
> >Thanks!
> >
> >
> >zhaojun <[email protected]&gt; 于2020年5月15日周五 上午10:06写道:
> >
> >&gt; LGTM, it looks jdbc and proxy is light enough after pluggable
> platform
> >&gt; complete.
> >&gt;
> >&gt; Regards,
> >&gt; cherrylzhao
> >&gt; -------------------------------------------------------
> >&gt; Email:[email protected]
> >&gt; Jun Zhao(cherrylzhao) Apache ShardingSphere
> >&gt;
> >&gt;
> >&gt; [email protected] <[email protected]&gt; 于2020年5月14日周四
> 下午10:35写道:
> >&gt;
> >&gt; &gt; Hi all,
> >&gt; &gt;
> >&gt; &gt; Apache ShardingSphere has lots of new features for new version
> 5.x.
> >&gt; &gt; It is better to aggregate and redesign modules.
> >&gt; &gt;
> >&gt; &gt; The current modules are:
> >&gt; &gt; ```
> >&gt; &gt; shardingsphere-spi
> >&gt; &gt; shardingsphere-sql-parser
> >&gt; &gt; shardingsphere-database-protocol
> >&gt; &gt; shardingsphere-underlying
> >&gt; &gt; sharding-jdbc
> >&gt; &gt; sharding-proxy
> >&gt; &gt; sharding-core
> >&gt; &gt; sharding-spring
> >&gt; &gt; sharding-orchestration
> >&gt; &gt; sharding-opentracing
> >&gt; &gt; sharding-metrics
> >&gt; &gt; sharding-transaction
> >&gt; &gt; sharding-scaling
> >&gt; &gt; master-slave-core
> >&gt; &gt; encrypt-core
> >&gt; &gt; shadow-core
> >&gt; &gt; control-panel
> >&gt; &gt; shardingsphere-integration-test
> >&gt; &gt;
> >&gt; &gt; ```
> >&gt; &gt;
> >&gt; &gt; There are serval points need to be adjusted:
> >&gt; &gt;
> >&gt; &gt; 1. There are 2 diff prefixes for `shardingsphere` and&nbsp;
> `sharding` we need
> >&gt; &gt; to unify. `sharding` is a feature name, and `shardingsphere` is
> too long,
> >&gt; &gt; so I prefer remove all prefixes.
> >&gt; &gt; 2. We have lots of features and may add more, so it is better to
> >&gt; aggregate
> >&gt; &gt; them to a parent modules.
> >&gt; &gt; 3. The orchestration related modules can be include in
> control-panel
> >&gt; &gt; module.
> >&gt; &gt; 4. It is better to rename shardingsphere-underlying to infra
> module
> >&gt; because
> >&gt; &gt; of it is more shortly and more make sense.
> >&gt; &gt;
> >&gt; &gt; So the draft of new modules are:
> >&gt; &gt;
> >&gt; &gt; ```
> >&gt; &gt; spi
> >&gt; &gt; sql-parser
> >&gt; &gt; db-protocol
> >&gt; &gt; infra
> >&gt; &gt; jdbc
> >&gt; &gt; proxy
> >&gt; &gt; spring
> >&gt; &gt; transaction
> >&gt; &gt; scaling
> >&gt; &gt; features
> >&gt; &gt;&nbsp;&nbsp; -- sharding
> >&gt; &gt;&nbsp;&nbsp; -- master-slave
> >&gt; &gt;&nbsp;&nbsp; -- encrypt
> >&gt; &gt;&nbsp;&nbsp; -- shadow
> >&gt; &gt; control-panel
> >&gt; &gt;&nbsp;&nbsp; -- orchestration
> >&gt; &gt;&nbsp;&nbsp; -- opentracing
> >&gt; &gt;&nbsp;&nbsp; -- metrics
> >&gt; &gt; integration-test
> >&gt; &gt; distribution
> >&gt; &gt; ```
> >&gt; &gt;
> >&gt; &gt; Any suggestion?
> >&gt; &gt;
> >&gt; &gt; ------------------
> >&gt; &gt;
> >&gt; &gt; Liang Zhang (John)
> >&gt; &gt; Apache ShardingSphere &amp; Dubbo
> >&gt; &gt;
> >&gt;
> >
> >
> >--
> >Haoran Meng
> >[email protected]
>

Reply via email to