Hi Kevin good job， i merged into master
thanks Kevin <[email protected]> 于2022年2月23日周三 22:35写道： > > Thanks for reviewing my code. I modified the code according to your > feedback. > But I ran into a problem[1]. > I've tried to solve it through the solutions on the internet, but it didn't > work. > Please help me to solve this problem. > > [1] : > https://github.com/apache/incubator-shenyu/pull/2928#discussion_r812822974 > > XiaoYu <[email protected]> 于2022年2月23日周三 19:49写道： > > > Hi Kevin > > > > Ok， i will review you pull request， thank you for contributor~ > > > > Kevin <[email protected]> 于2022年2月23日周三 17:32写道： > > > > > > Hi, Xiao Yu > > > > > > OK. With the help of the community I was able to build the project > > normally. > > > > > > I updated the password encryption method. After the local build is > > > completed, the related functions can be implemented as expected after > > > running. > > > I also passed before submitting pr[1] > > > mvn clean install -Dmaven.javadoc.skip=true > > > > > > Please review my pr if you have time. > > > > > > [1] https://github.com/apache/incubator-shenyu/pull/2928 > > > > > > XiaoYu <[email protected]> 于2022年2月23日周三 10:59写道： > > > > > > > Hi Kevin > > > > > > > > mybe it other unit test ，causes you problems，I am very concerned > > > > about this issue and trying to fix it. > > > > > > > > thanks for you contributor~ > > > > > > > > Kevin <[email protected]> 于2022年2月23日周三 01:46写道： > > > > > > > > > > Hi, Xiao Yu > > > > > > > > > > I have a very strange problem, to describe the problem, I use a lot > > of > > > > > code, please check this issue[1]. > > > > > > > > > > [1]: https://github.com/apache/incubator-shenyu/issues/1888 > > > > > > > > > > > > > > > XiaoYu <[email protected]> 于2022年2月22日周二 16:51写道： > > > > > > > > > > > Hi kevin， > > > > > > > > > > > > 1. you need eupdated sql to directly overwrite the sql in [1] (h2, > > > > > > mysql, pg)， and create 2 upgrade sql file(Includes mysql and pg) > > in > > > > > > [2] . > > > > > > like 2.4.2-upgrade-2.4.3-mysql.sql and > > 2.4.2-upgrade-2.4.3-pg.sql. > > > > > > > > > > > > 2. Maybe encrypt directly with sha-512 is better (method 2) > > > > > > > > > > > > [1]: > > > > > > > > > > > > https://github.com/apache/incubator-shenyu/tree/master/shenyu-admin/src/main/resources/sql-script > > > > > > [2]: https://github.com/apache/incubator-shenyu/tree/master/script > > > > > > > > > > > > Kevin <[email protected]> 于2022年2月22日周二 15:38写道： > > > > > > > > > > > > > > Hi，XiaoYu > > > > > > > Thanks for reminding me about updating sql. > > > > > > > Do I need to submit the updated sql to directly overwrite the > > sql in > > > > [1]? > > > > > > > Or provide a 2.4.2-upgrade-2.4.3-mysql.sql somewhere specified? > > > > > > > > > > > > > > about what you mentioned > > > > > > > > > > > > > > I think used SHA-512 with encrypt the password is better. > > > > > > > > > > > > > > > > > > > > > Method 1: Do you mean like the aes encryption function to > > encrypt the > > > > > > text > > > > > > > with a specified key? > > > > > > > SHA-512[1] does not support using a key to encrypt text, but we > > can > > > > add > > > > > > a > > > > > > > specified key to the text to generate encrypted text. > > > > > > > > > > > > > > Method 2 : Maybe you meant to encrypt directly with sha-512? > > > > > > > > > > > > > > I'm not quite sure if your opinion is method 1 or method 2, so > > > > wanted to > > > > > > > check with you. > > > > > > > > > > > > > > Regards > > > > > > > > > > > > > > [1]： > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-shenyu/tree/master/shenyu-admin/src/main/resources/sql-script > > > > > > > [2]：https://en.wikipedia.org/wiki/SHA-2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > XiaoYu <[email protected]> 于2022年2月22日周二 14:59写道： > > > > > > > > > > > > > > > Hi Kevin > > > > > > > > > > > > > > > > I have carefully read through your improvement plan for this > > > > issue[1]. > > > > > > > > > > > > > > > > I think used SHA-512 with encrypt the password is better. > > > > > > > > > > > > > > > > However, please note that the relevant SQL[2] are updated > > (insert > > > > into > > > > > > > > dashboard_user)，the default password is 123456. > > > > > > > > > > > > > > > > As there are sql statements involved, you will need to create > > the > > > > sql > > > > > > > > upgrade file，like 2.4.2-upgrade-2.4.3-mysql.sql or > > > > > > > > 2.4.2-upgrade-2.4.3-pg.sql in [3]. > > > > > > > > > > > > > > > > Looking forward to your pull request. > > > > > > > > > > > > > > > > Regards > > > > > > > > > > > > > > > > > > > > > > > > [1]: https://github.com/apache/incubator-shenyu/issues/1888 > > > > > > > > [2]: > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-shenyu/tree/master/shenyu-admin/src/main/resources/sql-script > > > > > > > > [3]: > > https://github.com/apache/incubator-shenyu/tree/master/script > > > > > > > > > > > > > > > > Kevin <[email protected]> 于2022年2月22日周二 14:41写道： > > > > > > > > > > > > > > > > > > Dear community friends: > > > > > > > > > > > > > > > > > > I answered a long time ago issue with a solution. > > > > > > > > > But I'm not sure if my solution is suitable for shenyu's > > needs. > > > > > > > > > If you are free, please see my solution and help me solve the > > > > problem > > > > > > > > > better. > > > > > > > > > > > > > > > > > > Issue: > > https://github.com/apache/incubator-shenyu/issues/1888 > > > > > > > > > > > > > > > > > > Regards > > > > > > > > > > > > > > > > > > > >
