Hi this pr [1], i alreay review. You should make the most minor changes.
Thank you for your contribution . [1]: https://github.com/apache/incubator-shenyu/issues/3112 XiaoYu <[email protected]> 于2022年3月24日周四 21:45写道： > hi > > it mybe shenyu.plugin.xxxx.enabled in Configurataion > > Han G <[email protected]> 于2022年3月24日周四 21:12写道： > >> Here I have a question. Which name convention we should follow? E.g. for >> context plugin, >> >> 1. shenyu.context.enabled >> 2. shenyu.plugin.context.enabled >> >> >> >> Which one is better? Currently, I think we follow the #1 style, like >> shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if >> any suggestion. >> >> >> >> Thanks, >> >> Han >> >> >> >> >> >> *From: *Han G <[email protected]> >> *Date: *Thursday, March 24, 2022 at 20:17 >> *To: *[email protected] <[email protected]> >> *Subject: *[TASK] Add configuration for all plugins to control if it >> will be loaded or not >> >> Hi all, >> >> >> >> Here is a proposal to add `enabled` configuration for all plugins. Like >> we did for metrics plugin. Related issue: >> https://github.com/apache/incubator-shenyu/issues/3112 >> >> >> >> I plan to do the similar thing for all the plugins and set it to >> `enabled` by default. Below is an example. >> >> >> >> Please let me know if any comment. 😊 >> >> >> >> Thanks, >> >> Han >> >> >> >
