Can we get those changes pushed upstream (I assume they'd be useful to everyone...)
On Tue, Feb 9, 2010 at 7:49 AM, Chris Chabot <chab...@google.com> wrote: > I think there were a few custom modifications to the oauth lib to make it > work as well, so a straight replacement will likely not work > > On Tue, Feb 9, 2010 at 3:53 PM, Eiji Kitamura <agek...@gmail.com> wrote: > > > Hi, > > > > I've tried to just drop the latest version of OAuth.php into external, > > but unfortunately, since members of OAuthRequest which used to be > > "protected" variables now are "private", it doesn't work straight > > away. > > Needs some modification to adopt. hmm > > > > 2010/2/5 Arne Roomann-Kurrik <kur...@google.com>: > > > There were several versions of OAuth.php in the codebase, and my Dec. > > patch > > > unified them into one place. It was taken from > > > http://oauth.googlecode.com/svn/code/php/ and newer versions of that > > library > > > should be able to be dropped in over it. > > > > > > ~Arne > > > > > > > > > On Thu, Feb 4, 2010 at 6:15 PM, Eiji Kitamura <agek...@gmail.com> > wrote: > > > > > >> Hi, > > >> > > >> > > >> I haven't tried to reproduce the issue but here's my guess. > > >> OAuth.php imported from google code was imported on 10th Dec. 2009 > > >> committed by Chris with patch submitted by Arne. (r889239). > > >> It is much later than the issue Thiago indicated, and it seems to be > > >> fixed by looking at OAuth.php line 707 in trunk. > > >> > > >> The latest OAuth commit was done by me which gives OAuth 1.0a > > >> compatibility. And there's still known issue that, resource url's > > >> query parameter not being included in base signature string. > > >> This was caused also by issue in original OAuth.php code and has been > > >> fixed. > > >> http://code.google.com/p/oauth/issues/detail?id=42 > > >> > > >> Again, I haven't tried to reproduce the issue Thiago raised, but > > >> OAuth1.0a is working fine on Twitter just by replacing OAuth.php with > > >> the latest one on google code. > > >> > > >> It's my bad not committing OAuth.php replacement but want to make sure > > >> it works and consider also about the issue SHINDIG-1284. > > >> > > >> > > >> Thiago, if your issue persists even by replacing OAuth.php, let me > know. > > >> > > >> Eiji. > > >> > > >> > > >> -- > > >> Eiji Kitamura > > >> http://devlog.agektmr.com/ > > >> http://twitter.com/agektmr > > >> > > >> 2010/2/5 Thiago Arrais <thiago.arr...@gmail.com>: > > >> > Thank you all for the pointers. It seems that the bug is already > fixed > > >> > in OAuth.php. I'll later try to file a patch integrating the fix > into > > >> > Shindig and/or upgrading it to the latest version (if it's not too > > hard). > > >> > > > >> > Cheers, > > >> > > > >> > Thiago Arrais > > >> > -- > > >> > Enjoy chaos - http://blog.thiagoarrais.com > > >> > Thoughts, ideas and useless ranting about software development and > > >> technology > > >> > > > >> > > > > > > > > > > > -- > > Eiji Kitamura > > http://devlog.agektmr.com/ > > http://twitter.com/agektmr > > >