http://codereview.appspot.com/593044/diff/1/3
File features/src/main/javascript/features/features.txt (right):

http://codereview.appspot.com/593044/diff/1/3#newcode54
features/src/main/javascript/features/features.txt:54:
features/osml/feature.xml
nit: out of order

http://codereview.appspot.com/593044/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
(right):

http://codereview.appspot.com/593044/diff/1/5#newcode113
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:113:
Map<String, Feature> directFeatures = gadget.getSpec().getModulePrefs()
why only direct?

http://codereview.appspot.com/593044/diff/1/5#newcode117
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:117:
if (f == null && directFeatures.containsKey("osml")) {
define "osml" as a public static final String

http://codereview.appspot.com/593044/show

Reply via email to