meta-comment: test?

http://codereview.appspot.com/1110041/diff/1/2
File
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java
(right):

http://codereview.appspot.com/1110041/diff/1/2#newcode100
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:100:
HttpUtil.setCORSheader(servletResponse);
This appears to be new; can't find any reference to it in httpu...@head.

http://codereview.appspot.com/1110041/diff/1/2#newcode175
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:175:
String callback =  (HttpUtil.isJSONP(servletRequest) &&
ContentTypes.OUTPUT_JSON_CONTENT_TYPE.equals(converter.getContentType()))
?
nit: reduce this line to 100 char

http://codereview.appspot.com/1110041/diff/1/2#newcode180
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:180:
if (callback != null) writer.write(");\n");
this whole chunk of new code can probably be pulled into an HttpUtil
helper no?

http://codereview.appspot.com/1110041/show

Reply via email to