This actually isn't backward-compatible. Set<String> is unordered, whereas the previous ordered array makes it possible to override existing feature declarations. For instance, we have a custom rpc/feature.xml override of the Shindig default.
--j On Thu, May 13, 2010 at 6:58 AM, Paul Lindner <lind...@inuus.com> wrote: > Here's the next step towards allowing a shindig plugin architecture. This > one allows external modules to add their javascript features to the > FeatureRegistry. > > It's backwards compatible with the way we currently inject feature > directories (via shindig.features.default) so I'm going to commit this soon > unless there are objections. > > On Thu, May 13, 2010 at 6:53 AM, <lind...@inuus.com> wrote: > > > Reviewers: shindig.remailer_gmail.com, > > > > > > > > Please review this at http://codereview.appspot.com/1197041/show > > > > Affected files: > > M > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java > > M > > > java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java > > M > > > java/gadgets/src/test/java/org/apache/shindig/gadgets/features/FeatureRegistryTest.java > > M > > > java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java > > > > > > >
