True, it's really just a relatively minor structuring nit. --j
On Sat, May 22, 2010 at 7:00 AM, <[email protected]> wrote: > > http://codereview.appspot.com/1240043/diff/9001/10001 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > (right): > > http://codereview.appspot.com/1240043/diff/9001/10001#newcode172 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java:172: > protected String generateSecurityToken(Gadget gadget) { > On 2010/05/22 02:40:03, johnfargo wrote: > >> didn't enjoy the wantsSecurityToken(gadget) idea? >> > > Sure I'll modify the patch to do that; however it seems like you could > just return null here to signal the same thing.. > > > http://codereview.appspot.com/1240043/show >
