On Mon, Jun 14, 2010 at 3:06 PM, <[email protected]> wrote: > On 2010/06/14 17:22:23, johnfargo wrote: > >> +1 to that. The reason you can't copy-and-paste the URL into your >> > browser > >> bar is that the URL is unescaped by the browser when it's the value of >> > a > >> target attribute ie src="value". >> > > I chatted with zhoresh and i think now i understand why the browser > would want all &'s to be replaced by & > So ideally, the best thing would be to take care of all the & escaping > in html serializer itself. > However, I would not want to change something that breaks current > functionality :( > > I'l try enumerating all possible cases and try to change only the > DefaultHtmlSerializer file. This way, all the logic for escaping "&" > and other escape characters like "quotes" will reside in only place and > it would be cleaner. > If you feel that approach is better, we can slowly start removing > stringreplace("&", "&") from places like ConcatVisitor and > RenderingGadgetRewriter after we are sure that we nailed down all > possible scenarios. > > Sound reasonable ? >
That sounds reasonable to me. I agree that proper encapsulation has HtmlSerializer taking care of this exclusively. > > Btw, the Copy Location url not working when pasted into browser > navigation bar is really annoying. The first thing that comes to mind is > that somehow the url was not generated correctly. > Maybe we should find out why google.com does not choose to escape &. > Does google not bother about html standard, or does it assume that most > famous browsers already take care of it ? Good question, and worth asking to various parties. Anyone from Shindig know why this is generally-accepted practice? > > > Re: the XSRF issue on codereview, that happens occasionally with the >> > tool > >> and is orthogonal. I've seen it occur when you start an operation but >> > don't > >> complete it within a period of time (in the tool). A refresh usually >> > fixes > >> the problem. >> > > Yeah this went away when i refreshed, but my original comment was lost > :( Sadness :( > > --j >> > > On Mon, Jun 14, 2010 at 10:12 AM, Ziv Horesh >> > <mailto:[email protected]> wrote: > > > >> > > > http://codereview.appspot.com/1632042/show >
