And don't forget to write tests...
http://codereview.appspot.com/1626044/diff/5001/6002 File java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java (right): http://codereview.appspot.com/1626044/diff/5001/6002#newcode498 java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java:498: if (body == null || !(body instanceof MutableContent.ByteArrayContentBytes)) { I would postpond detection to the time you need it. The encoding is really needed only in the case of batch request, so at that point you should have all data. http://codereview.appspot.com/1626044/diff/5001/6003 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java (right): http://codereview.appspot.com/1626044/diff/5001/6003#newcode296 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:296: bufferedStream = IOUtils.toByteArray(getStream()); What if someone already ask to get the stream? http://codereview.appspot.com/1626044/diff/5001/6003#newcode301 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:301: return bufferedStream; Set streamReturned to true http://codereview.appspot.com/1626044/diff/5001/6003#newcode314 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java:314: return stream; Set streamReturned to true http://codereview.appspot.com/1626044/show
