Your choice.. Personally I'm fine with injecting an Executor for this..
On Jun 21, 2010, at 6:44 PM, John Hjelmstad wrote: > -shindig-dev, +dev > > On Mon, Jun 21, 2010 at 6:43 PM, John Hjelmstad <[email protected]> wrote: > >> Sorry about that Paul -- I'd intended actually to make the injection >> (optional=true), so that the status quo behavior (sequential loads) is >> maintained. Thoughts? >> >> --j >> >> >> On Mon, Jun 21, 2010 at 6:33 PM, <[email protected]> wrote: >> >>> Author: lindner >>> Date: Tue Jun 22 01:33:26 2010 >>> New Revision: 956759 >>> >>> URL: http://svn.apache.org/viewvc?rev=956759&view=rev >>> Log: >>> need a concat executor or we can't start up.. >>> >>> Modified: >>> >>> shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java >>> >>> Modified: >>> shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java >>> URL: >>> http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java?rev=956759&r1=956758&r2=956759&view=diff >>> >>> ============================================================================== >>> --- >>> shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java >>> (original) >>> +++ >>> shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java >>> Tue Jun 22 01:33:26 2010 >>> @@ -68,6 +68,7 @@ public class DefaultGuiceModule extends >>> >>> final ExecutorService service = >>> Executors.newCachedThreadPool(DAEMON_THREAD_FACTORY); >>> bind(Executor.class).toInstance(service); >>> + >>> bind(Executor.class).annotatedWith(Names.named("shindig.concat.executor")).toInstance(service); >>> bind(ExecutorService.class).toInstance(service); >>> Runtime.getRuntime().addShutdownHook(new Thread() { >>> public void run() { >>> >>> >>> >>
