Compute log output only if needed (issue1702047)

Mon, 28 Jun 2010 10:40:21 -0700 

Reviewers: dev-remailer_shindig.apache.org,

Description:
This patch adds a check to see if the current log level is set to
FINE[ST] before computing the log output and passing it to
Logger#fine[st]. I checked that all other places already have this kind
of check in place.

Please review this at http://codereview.appspot.com/1702047/show

Affected files:
java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
Index: java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java 
===================================================================
--- java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java (revision 958644) +++ java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java (working copy) 
@@ -23,6 +23,7 @@
 import org.apache.shindig.gadgets.GadgetContext;

 import java.io.IOException;
+import java.util.logging.Level;
 import java.util.logging.Logger;

 import javax.servlet.http.HttpServletRequest;
@@ -49,7 +50,9 @@
   @Override
protected void doGet(HttpServletRequest request, HttpServletResponse response) 
       throws IOException {
-    logger.fine("accel request = " + request.toString());
+    if (logger.isLoggable(Level.FINE)) {
+      logger.fine("accel request = " + request.toString());
+    }
     accelHandler.fetch(request, response);
   }
Index: java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java 
===================================================================
--- java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java (revision 957790) +++ java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java (working copy) 
@@ -25,6 +25,7 @@
 import org.w3c.dom.Element;
 import org.w3c.dom.NodeList;

+import java.util.logging.Level;
 import java.util.logging.Logger;

 /**
@@ -41,7 +42,7 @@
       Element baseElement = (Element) list.item(i);
       baseElement.getParentNode().removeChild(baseElement);

-      if (baseElement.hasAttribute("href")) {
+ if (baseElement.hasAttribute("href") && logger.isLoggable(Level.FINE)) { 
         logger.fine("Removing base tag pointing to: "
                     + baseElement.getAttribute("href") + " for gadget: "
                     + gadget.getContext().getUrl().toString());
Index: java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java

Reply via email to