On Fri, Jul 16, 2010 at 3:26 PM, Michael Young <[email protected]>wrote:
> Hi John,
>
> I've begun doing this, but I ran into a few problems:
>
> 1) Right now it's not very easy to override the Guice binding to
> JsUriManager. I had to subclass DefaultGuiceModule and UriModule and copy
> the configure() methods in my subclasses to swap it out.
>
> 2) DefaultJsUriManager does not like %host%. Specifically, somewhere in
> Uri.parse(jsHost) it creates a java.net.Uri, and it doesn't like %host%
> naturally. I can work around this by completely reimplementing
> DefaultJsUriManager. While possible, it seems to be a lot of bandaging to
> get some old functionality back.
> 3) container.js still references %host%. Obviously this must work in
> somebody's test environnment, but not the sample / default env.
>
> You mentioned that in your implementation you have overridden behavior to
> support %host%. It works for you?
>
True about the %host% parsing issue. I can think of two fixes:
1. Modify DefaultJsUriManager's getReqConfig(config, JS_HOST_PARAM) line to
delegate to a new protected method getHost(), whose default impl uses
ContainerConfig.
2. Simulate the same thing by creating a delegating ContainerConfig
implementation that replaces %host% for values it returns. You'll need a
context object for this; a ThreadLocal could do in a pinch, while waiting
for the base class to be updated as per #1.
--j
>
> Thanks again for the help.
>
> - Mike
> --
> Liferay West Coast Symposium
> September 8-9, 2010
> Anaheim, CA
> www.liferay.com/wcs
> --
> Follow us on Twitter: liferay
>
> On Jul 9, 2010, at 5:17 PM, John Hjelmstad wrote:
>
> > %host% is a regression to some degree... though is useful, and is in need
> of
> > a replacement. Given 2.0 is a breaking API release, it was removed.
> > Rationale is that its logic was being sprinkled throughout the code, with
> > the substitution coming from gadget.getContext().getHost(). IMO better
> would
> > be to have a more general injected context object that, for instance,
> > ContainerConfig would use.
> >
> > To support it in the interim, you can subclass DefaultJsUriManager and
> > perform the replacement:
> > Uri uri = super.makeExternJsUri();
> > if (uri.toString().contains("%host%")) {
> > uri = new UriBuilder(uri.replaceAll("%host%",
> > gadget.getContext().getHost())).toUri();
> > }
> > return uri;
> >
> > %js% was replaced with a better-structured host/path based config
> mechanism.
> > Let me know if there's a use case its removal breaks.
> >
> > --j
> >
> > On Fri, Jul 9, 2010 at 4:29 PM, Michael Young <[email protected]
> >wrote:
> >
> >> DefaultURLGenerator used to substitute these tokens. Is this a
> regresssion,
> >> or is there an alternative way to specify values for host and js at
> runtime?
> >>
> >>
> >>
> >> - Mike
> >> --
> >> Liferay West Coast Symposium
> >> September 8-9, 2010
> >> Anaheim, CA
> >> www.liferay.com/wcs
> >> --
> >> Follow us on Twitter: liferay
> >>
> >>
>
>
