On Sun, Jul 25, 2010 at 9:00 PM, Gagandeep Singh <gagan.g...@gmail.com>wrote:
> > On Mon, Jul 26, 2010 at 9:21 AM, <jas...@gmail.com> wrote: > >> >> StyleTagProxyEmbeddedUrlsVisitorTest.testImportsAndBackgroundUrlsInStyleTag() >> is incorrect. According the W3C CSS2 spec >> http://www.w3.org/TR/CSS2/syndata.html#at-rules: CSS 2.1 user agents >> must ignore any '@import' rule that occurs inside a block or after any >> non-ignored statement other than an @charset or an @import rule. > > >> I've changed the test case to test what I assume was intended to be >> tested (an unignored @import), synced and submitted. >> > Makes sense. Out of curiosity, caja must be ignoring @import statement > after a non ignorable css statement [ which is probably why that test failed > :) ] > If so, is there a flag asking it to not do so ? It could come in handy if > we find a user agent that does not ignore such statements and want to > emulate its behavior. > > >> >> (Incidentally the submission was made while at 10969m and traveling at >> the speed of at 822km/h. Is this a contender for the Shindig patch made >> at the greatest height and speed? :) ) > > > Nice ! Travelling in first class eh :) > Definitely a solid contestant id say. > Contestant, yes. Winner: I regret to say no. I made a commit a few weeks ago @37k ft and (tailwind assist) 590 mph :P > > >> >> http://codereview.appspot.com/1852041/show >> > >
