LGTM, committing w/ one FYI to those reading.

http://codereview.appspot.com/1811042/diff/54001/55005
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java
(right):

http://codereview.appspot.com/1811042/diff/54001/55005#newcode147
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java:147:
resp.setStatus(HttpResponse.SC_BAD_GATEWAY);
This is the only potentially controversial change left in this CL, but
it LGTM. It presumes that the calling context will supply error content
that exists, if any. This is true for all callers (Accel only for the
moment).

http://codereview.appspot.com/1811042/show

Reply via email to