lgtm

http://codereview.appspot.com/1867046/diff/1/2
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
(right):

http://codereview.appspot.com/1867046/diff/1/2#newcode146
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:146:
// Skip illegal header
This is fine for now but probably the right way of fixing this issue
everywhere is to use UriUtils.isValidHeaderName and
UriUtils.isValidHeaderValue.
Though UriUtils.isValidHeaderValue is not yet implemented, it might make
sense to do that. The rfc is clear on what values are acceptable for
header names and values.
Also, see http://codereview.appspot.com/1855044/diff/45001/46005 for
another way of refactoring ProxyHandler.

http://codereview.appspot.com/1867046/show

Reply via email to