Patch partially applied.

thanks!

Will go over the overlapping changes more closely tomorrow.


http://codereview.appspot.com/1247044/diff/55001/56014
File features/src/main/javascript/features/core.util/util.js (left):

http://codereview.appspot.com/1247044/diff/55001/56014#oldcode127
features/src/main/javascript/features/core.util/util.js:127: parameters
= {};
lgtm, will commit with some mods

http://codereview.appspot.com/1247044/diff/55001/56014
File features/src/main/javascript/features/core.util/util.js (right):

http://codereview.appspot.com/1247044/diff/55001/56014#newcode369
features/src/main/javascript/features/core.util/util.js:369: 'byId' :
function(id) {
This is only used in pubsub-2, move to that namespace?

http://codereview.appspot.com/1247044/diff/55001/56015
File
features/src/main/javascript/features/shindig.container/shindig-container.js
(right):

http://codereview.appspot.com/1247044/diff/55001/56015#newcode805
features/src/main/javascript/features/shindig.container/shindig-container.js:805:
// OAAIfrGadget
remove commented code?

http://codereview.appspot.com/1247044/show

Reply via email to