http://codereview.appspot.com/2119043/diff/63001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java
(right):

http://codereview.appspot.com/2119043/diff/63001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java#newcode65
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParserRouter.java:65:
public void setHtmlParserFromName(String htmlParserName) {
My 2 cents is I am not too sure about additional setHtmlParserFromName
public method in this class which is not expose in the
GadgetHTMLRenderer.

If iterating through existing parsers is really desired we could
probably make the router as factory which does not extend the
GadgetHTMLParser instead. Because essentially thats what the router is
doing, right?
And we could also use the Map binding as Paul suggested in the
implementation.

http://codereview.appspot.com/2119043/

Reply via email to