LGTM.

Also, please ask on the dev community / add TODO's in the right places
to test with images when huffman is enabled.
You can look at the revision history of image optimizations directory to
find the right person to ask:
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/


http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java
(right):

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java#newcode54
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java:54:
* Defaults
would be nice if you mention that these are being used only for tests.

http://codereview.appspot.com/2322042/

Reply via email to