http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java File java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java (right):
http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java#newcode112 java/common/src/main/java/org/apache/shindig/config/BasicContainerConfig.java:112: observers.add(observer); upon adding a new config observer, we could opt to simply call: observer.containersChanged(this, config.keySet(), <empty collection or null>); http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java File java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java (right): http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java#newcode41 java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:41: * (${foo.bar}). while we're cleaning up comments, we could update this indicating the classes that implement the default impls http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java#newcode169 java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:169: * changed. nit: w/ 100-char width this could be on one line. http://codereview.appspot.com/2773041/diff/1/java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java#newcode171 java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java:171: * modified. same http://codereview.appspot.com/2773041/
