It looks a little odd:
1) to see internal instance variables directly referred by a utility/helper
class.
2) mixins_ used outside of the shindig.container.Container scope.
Suggesting a simple change to (statically) add addMixin() on
shindig.container.Container, like below --
shindig.container.Container.addMixin = function(namespace, func){
shindig.container.Container.prototype.mixins_[namespace] = func;
}
With this, we also get a shorter function name than addContainerMixin(),
because it is clear it is acting on the "container".
Please keep spaces consistent to 2 spaces, not tabs.
Sorry for chiming in late.
On Tue, Mar 8, 2011 at 6:18 PM, <[email protected]> wrote:
> Updated patch with suggested changes
>
>
> http://codereview.appspot.com/4260049/
>
