> On 2011-05-20 01:37:25, Ryan Baxter wrote: > > trunk/java/common/src/main/java/org/apache/shindig/auth/AuthenticationServletFilter.java, > > line 146 > > <https://reviews.apache.org/r/760/diff/1/?file=19450#file19450line146> > > > > Ah I see, so what's the point of passing in the request object then? > > Would classes which extend this class need that object for something? (Not > > really familiar with what this code does, I was just taking a look at your > > changes.)
Thanks for the review. I was thinking if a class extending it needs request to get information to build the realm such as hostname, some request parameters, etc. The idea was to make developers life easier when they have to extend default functionality. In this case they dont have to copy-paste the logic in the doFilter method. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/760/#review693 ----------------------------------------------------------- On 2011-05-19 18:47:32, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/760/ > ----------------------------------------------------------- > > (Updated 2011-05-19 18:47:32) > > > Review request for shindig. > > > Summary > ------- > > Update the AuthenticationServletFilter: > 1. Make the auth realm configurable via property or override able protected > method. > 2. Sets the auth header from the right handler. Currently the code sets the > response's WWW-Authenticate header whenever an auth handler return null st. > So if the next handler return a security token, the response contains > WWW-Authenticate header from previous handler. This CR change the logic to > only add WWW-Authenticate header if token is not set or > InvalidAuthenticationException is thrown. > > > Diffs > ----- > > > trunk/java/common/src/main/java/org/apache/shindig/auth/AuthenticationServletFilter.java > 1125043 > > trunk/java/common/src/test/java/org/apache/shindig/auth/AuthenticationServletFilterTest.java > 1125043 > > Diff: https://reviews.apache.org/r/760/diff > > > Testing > ------- > > Update unit test for null st. > > > Thanks, > > Henry > >
