Re: A gadget lifecycle registry for the container (issue4536097)

[igor1x]

Some clarifications.


http://codereview.appspot.com/4536097/diff/1/features/src/main/javascript/features/container/container.js
File features/src/main/javascript/features/container/container.js
(right):

http://codereview.appspot.com/4536097/diff/1/features/src/main/javascript/features/container/container.js#newcode35
features/src/main/javascript/features/container/container.js:35: * @type
{Array} array of callback objects, all of which have an "preloaded",
"navigated", "closed" and "unloaded" methods.
On 2011/06/07 09:58:58, plindner1 wrote:

Array of what?

I think you want functions that take optional objects.

Each element of the array would look like this:

var containerCallback = new Object();
  containerCallback.preloaded=function(data){};
  containerCallback.closed=function(data){};
  containerCallback.navigated=function(data){};
  containerCallback.unloaded=unloaded(data){};

http://codereview.appspot.com/4536097/diff/1/features/src/main/javascript/features/container/container.js#newcode665
features/src/main/javascript/features/container/container.js:665: *
@param {data} data to be passed to the callback method
On 2011/06/07 09:58:58, plindner1 wrote:

data is not a type.  Maybe {Object}

is data optional?  If it is rename to opt_data and use {Object?}

See http://code.google.com/closure/compiler/docs/js-for-compiler.html

Changing to {Object}--it is a required parameter.

http://codereview.appspot.com/4536097/