----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/939/#review871 -----------------------------------------------------------
Ship it! LGTM. thanks for addressing it. - li On 2011-06-21 15:15:51, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/939/ > ----------------------------------------------------------- > > (Updated 2011-06-21 15:15:51) > > > Review request for shindig. > > > Summary > ------- > > Remove scheme from default test domain/host name in the config/container.js. > > Also make the gadgets.uri.iframe.unlockedDomain is free from // and add it in > the default Iframe URL manager to avoid opaque URL. > > > Diffs > ----- > > trunk/config/container.js 1137864 > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > 1137864 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java > 1137864 > > Diff: https://reviews.apache.org/r/939/diff > > > Testing > ------- > > Modify unit test. > > > Thanks, > > Henry > >
