----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1011/ -----------------------------------------------------------
Review request for shindig. Summary ------- Previously, the common container code did not register the RPC handler for setprefs. It was completely up to the container to register for the rpc handler and to supply the render calls with the persisted preference data. This patch surfaces some simple hooks that a container may provide for persisting and retrieving persisted preferences. This patch also changes the behavior of the common container code to ask for gadget metadata with the navigator's language settings. There are also 2 simple hooks to allow the container to override this default behavior. One change of particular note: a gadget site id is now a string, and is set-able by the container via the site element's id attribute. This is to allow a container to persist an instance of a gadget instance (and thus a gadget instance's preferences). Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1142113 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1142113 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1142113 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js 1142113 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/service_test.js 1142113 Diff: https://reviews.apache.org/r/1011/diff Testing ------- Tested in a private container. Updated tests to test language callbacks. Thanks, Dan
