> On 2011-07-11 15:46:53, Paul Lindner wrote: > > trunk/content/samplecontainer/examples/commoncontainer/assembler.js, line 31 > > <https://reviews.apache.org/r/1067/diff/1/?file=22237#file22237line31> > > > > Optional: add a comment about how this requires use of the default > > security token config?
Good idea, will absolutely do. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1067/#review1023 ----------------------------------------------------------- On 2011-07-11 07:02:12, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1067/ > ----------------------------------------------------------- > > (Updated 2011-07-11 07:02:12) > > > Review request for shindig. > > > Summary > ------- > > Remove the TestSecurityTokenCodec for common container to make the OAuth > gadget works by allowing DefaultSecurityTokenCodec to create the right st. > > > Diffs > ----- > > trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1145041 > > trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerAuthGuiceModule.java > 1145041 > > trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/CommonContainerSecurityTokenCodec.java > 1145041 > > trunk/java/server/src/main/java/org/apache/shindig/sample/commoncontainer/auth/TestSecurityTokenCodec.java > 1145041 > trunk/java/server/src/main/webapp/WEB-INF/web.xml 1145041 > > Diff: https://reviews.apache.org/r/1067/diff > > > Testing > ------- > > pass unit test and run gadgets in common container sample page. > > > Thanks, > > Henry > >
