----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/982/ -----------------------------------------------------------
(Updated 2011-07-18 20:13:13.170550) Review request for shindig, Ryan Baxter, Stanton Sievers, and Dan Dumont. Changes ------- New patch addresses issues and contains a sample gadget called dynamicWidthTest.xml located under samplecontainer/examples As far as I could tell, var _IG_AdjustIFrameWidth isn't used anywhere, but a similarly unused variable was kept in the dynamic-height feature so I left it for consistency. Summary ------- This is the reference implementation for the dynamic width OpenSocial spec change: http://code.google.com/p/opensocial-resources/issues/detail?id=1191&colspec=ID%20Type%20Container%20Stars%20Summary%20Status This change also incorporates the change posed here: https://reviews.apache.org/r/974/ That change is necessary in order for the rpc callback in Dynamic Width to function properly. Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/dynamicWidthTest.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/feature.xml 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/dynamic-height-util.js 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/feature.xml 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.util/taming.js 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height/feature.xml 1147953 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1147953 Diff: https://reviews.apache.org/r/982/diff Testing ------- Tested against Firefox 3.6, Chrome 12, Safari 5 in a custom container Thanks, cheelan
