----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1152/#review1135 -----------------------------------------------------------
Ship it! LGTM - Henry On 2011-07-20 15:58:24, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1152/ > ----------------------------------------------------------- > > (Updated 2011-07-20 15:58:24) > > > Review request for shindig, Paul Lindner, Henry Saputra, and Eric Woods. > > > Summary > ------- > > This patch would address a bug introduced from previous revision. Sample > html doesn't run out of box when shindig is deployed with context root other > than "ROOT". > Relative path is used to load container and css files. > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/commoncontainer/index.html 1148651 > > Diff: https://reviews.apache.org/r/1152/diff > > > Testing > ------- > > Passed tests. > > Deployed shindig.war under any contextRoot and tested gadgets with common > container api on following sample page: > http://localhost:8080/<contextroot>/samplecontainer/examples/commoncontainer/index.html > > Todo and horoscope gadgets are not rendered but that's a separate bug. It > failed even with "ROOT" as context root. All the other sample gadgets work. > > > Thanks, > > li > >
