----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1224/#review1232 -----------------------------------------------------------
Is there requirement or scenario where these need to be exposed as abstract methods? Seems like default code should work. I am just wondering what would be the situation where you need different behavior. - Henry On 2011-07-29 21:03:19, csong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1224/ > ----------------------------------------------------------- > > (Updated 2011-07-29 21:03:19) > > > Review request for shindig, johnfargo and Ziv Horesh. > > > Summary > ------- > > abstracted out 2 methods > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/ConfigInjectionProcessor.java > 1152332 > > Diff: https://reviews.apache.org/r/1224/diff > > > Testing > ------- > > > Thanks, > > csong > >
