-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1564/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Currently the common container is hard coded to make a gadgets.token OSAPI call 
back to Shindig when refreshing security tokens.

I'm attaching a patch which allows users of the common container to override 
that default behavior by providing a custom function to use instead. I've 
followed the same pattern which is already in place for the GET_PREFERENCES 
override for providing a custom function for fetching gadget preferences.

If this looks good to everyone I would be happy to go ahead and submit a patch 
against the container specification for this change as well. 


This addresses bugs RAVE-198 and SHINDIG-1580.
    https://issues.apache.org/jira/browse/RAVE-198
    https://issues.apache.org/jira/browse/SHINDIG-1580


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
 1157893 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js
 1158700 

Diff: https://reviews.apache.org/r/1564/diff


Testing
-------

Tested in browser using sample common container.


Thanks,

Jesse

Reply via email to