----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1603 -----------------------------------------------------------
One more thing Li, please create a JIRA and attach the patch to it. Then put the link to it in the Bugs section of the review. (You should be able to just put SHINDIG-xxxx and it will link the review and the JIRA.) - Ryan On 2011-08-23 21:47:22, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1616/ > ----------------------------------------------------------- > > (Updated 2011-08-23 21:47:22) > > > Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. > > > Summary > ------- > > This fix enables EE sample page to work out of box even if it's deployed with > a context root other than root or port other than 8080 > > we added two tokens at sample db: canonicaldb.json > %contextroot% > %origin% > it's resolved by JsonDBOpensocialService.java based on injected hostProvider > This is a generic change... any other opensocial object could use the same > token in sample json db. > > Opensocial sample context is updated to include an additional attribute since > photogadget.xml need to refer to AlbumViewer.xml > "eeGadget" : > "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml", > fixed related junit tests. > > Thanks to Ryan's help on this! > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > 1160372 > /trunk/content/samplecontainer/examples/embeddedexperiences/index.html > 1160372 > /trunk/content/sampledata/canonicaldb.json 1160372 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1160372 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml > 1160372 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json > 1160372 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json > 1160372 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json > 1160372 > > /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml > 1160372 > > Diff: https://reviews.apache.org/r/1616/diff > > > Testing > ------- > > Passed JUnit tests. > Tested with /embeddedexperiences/index.html > > > Thanks, > > li > >
