Hi Jacobo, Could you please create a JIRA issue for this and attach the patch or link the review to it.
Thanks, - Henry On Wed, Aug 24, 2011 at 5:37 PM, Jacobo Tarrío <jtar...@gmail.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1648/ > ----------------------------------------------------------- > > Review request for shindig and johnfargo. > > > Summary > ------- > > According to the RFC, ETags have to be in quote signs. Also, the > If-None-Matches header can specify several ETags, separated with commas. This > has been added to the ETaggingHttpResponse. No weak ETag generation or > checking, though. > > > Diffs > ----- > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java > 1161302 > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETagFilterTest.java > 1161302 > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponseTest.java > 1161302 > > Diff: https://reviews.apache.org/r/1648/diff > > > Testing > ------- > > > Thanks, > > Jacobo > >
