----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1680/#review1693 -----------------------------------------------------------
This OAuth 2.0 client implementation looks good so far. Thanks Bastian for jumping on this! /trunk/php/src/gadgets/oauth/OAuth2Fetcher.php <https://reviews.apache.org/r/1680/#comment3852> This look good to me here though Eric has more experience on the client side. But the flow looks correct, etc. Review tool has picked up a few extra spaces in this file that could be cleaned up. /trunk/php/src/gadgets/oauth/OAuthService.php <https://reviews.apache.org/r/1680/#comment3851> This works for now, though we are looking to add a separate OAuth2 element for registering OAuth 2.0 service endpoints rather than overloading the existing OAuth configuration. As of today, this hasn't made it into the draft yet. See http://code.google.com/p/opensocial-resources/issues/detail?id=1209 - Matt On 2011-08-30 13:46:53, Bastian Hofmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1680/ > ----------------------------------------------------------- > > (Updated 2011-08-30 13:46:53) > > > Review request for shindig, Matt Marum and Eric Woods. > > > Summary > ------- > > Hi, > > this is the first take on implementing OAuth2 support for proxied content in > PHP. It still only works with gadgets.io.makeRequest and not with osapi.http. > > Still todo: Mostly unit tests since there were no tests for the OAuth1 > implementation to begin with. But, since it's a big change and the Java > implementation is ongoing at the moment as well, I wanted to get this out and > get feedback on it as early as possible. > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/core.io/io.js 1162190 > > /trunk/features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js > 1162190 > /trunk/php/src/common/RemoteContentRequest.php 1162668 > /trunk/php/src/common/sample/BasicRemoteContent.php 1162668 > /trunk/php/src/gadgets/MakeRequest.php 1162668 > /trunk/php/src/gadgets/MakeRequestOptions.php 1162668 > /trunk/php/src/gadgets/oauth/GadgetOAuthTokenStore.php 1162668 > /trunk/php/src/gadgets/oauth/OAuth2Fetcher.php PRE-CREATION > /trunk/php/src/gadgets/oauth/OAuthFetcher.php 1162668 > /trunk/php/src/gadgets/oauth/OAuthFetcherFactory.php 1162668 > /trunk/php/src/gadgets/oauth/OAuthService.php 1162668 > /trunk/php/src/gadgets/servlet/OAuthCallbackServlet.php 1162668 > > Diff: https://reviews.apache.org/r/1680/diff > > > Testing > ------- > > > Thanks, > > Bastian > >
