Thanks Mat and Henry for pushing this patch through! I've got one other fairly simple review open which will also result in a common container spec change, so once that one is done as well I'll go ahead and open ticket for spec changes for both of them.
The review for the other change is here: https://reviews.apache.org/r/1563/ There has already been additional discussion for that one and I think Ryan was ready to commit it pending a quick review from Mike Hermanto, however Mike never responded. Is there someone else who can help push that one through too? Thanks! >-----Original Message----- >From: Henry Saputra (JIRA) [mailto:j...@apache.org] >Sent: Tuesday, September 13, 2011 8:20 PM >To: Ciancetta, Jesse E. >Subject: [jira] [Resolved] (SHINDIG-1580) Allow for custom security token >fetch function to be used when refreshing security tokens > > > [ https://issues.apache.org/jira/browse/SHINDIG- >1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > >Henry Saputra resolved SHINDIG-1580. >------------------------------------ > > Resolution: Fixed > >Closed with rev #1170371 > >> Allow for custom security token fetch function to be used when refreshing >security tokens >> ----------------------------------------------------------------------------------------- >> >> Key: SHINDIG-1580 >> URL: https://issues.apache.org/jira/browse/SHINDIG-1580 >> Project: Shindig >> Issue Type: Improvement >> Reporter: Jesse Ciancetta >> Fix For: 3.0.0 >> >> Attachments: gadget-token.patch >> >> >> Currently the common container is hard coded to make a gadgets.token >OSAPI call back to Shindig when refreshing security tokens. >> I'm attaching a patch which allows users of the common container to >override that default behavior by providing a custom function to use instead. >I've followed the same pattern which is already in place for the >GET_PREFERENCES override for providing a custom function for fetching >gadget preferences. >> If this looks good to everyone I would be happy to go ahead and submit a >patch against the container specification for this change as well. > >-- >This message is automatically generated by JIRA. >For more information on JIRA, see: http://www.atlassian.com/software/jira > >
