> On 2011-09-14 22:16:56, Ryan Baxter wrote: > > LGTM Dan. My one concern is that there is existing code that depends on > > the old behavior. Are there any unit tests around this code? Can you > > think of any way to figure out if there is any code that depends on the old > > behavior? Just want to know how certain we are that this is not going to > > bite us.
We've been running with this change for quite a while now and I haven't seen any negative consequences to the change. It has been instrumental though in allowing us to load a container into a page on another domain. If anyone knows of any unit tests specifically related to this area I can investigate and create more. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1211/#review1898 ----------------------------------------------------------- On 2011-08-12 14:44:17, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1211/ > ----------------------------------------------------------- > > (Updated 2011-08-12 14:44:17) > > > Review request for shindig. > > > Summary > ------- > > While debugging using a container cross-site from where shindig is hosted, I > ran into trouble using: > config[osapi.container.ServiceConfig.API_PATH] = '/rpc'; > config[osapi.container.ServiceConfig.API_HOST] = // A url to a proxy on the > host server that points to the shindig server. > > I found that the osapi.container.Service.prototype.registerOsapiServices > function was defining methods that never ended up sticking, because other > methods would beat it to the punch. > This resulted in the above settings never taking hold. > > > This addresses bug SHINDIG-1569. > https://issues.apache.org/jira/browse/SHINDIG-1569 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/osapi.base/osapi.js > 1151610 > > Diff: https://reviews.apache.org/r/1211/diff > > > Testing > ------- > > Tested navigate gadget in a cross-hosted container environment (vanilla web > host loading CC from shindig server). > Tested navigate gadget in SampleContainer (same host). > > > Thanks, > > Dan > >
