----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2052/#review2086 -----------------------------------------------------------
There's another fix to this problem that addresses the issue expressed by Doug Davies in the dev list. instead of forcing people to register an API_PATH for the common container, we should by default NOT register an api path if it is not explicitly provided. Let me know if you want to go after it, otherwise it's on my to do list. - Dan On 2011-09-26 21:22:35, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2052/ > ----------------------------------------------------------- > > (Updated 2011-09-26 21:22:35) > > > Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. > > > Summary > ------- > > The fix will set up API patch when common container is created in these > sample pages. > > var testConfig = testConfig || {}; > testConfig[osapi.container.ServiceConfig.API_PATH] = contextRoot + '/rpc'; > var CommonContainer = new osapi.container.Container(testConfig); > > also includes other minor cleanup. > > > Diffs > ----- > > > /trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1176015 > /trunk/content/samplecontainer/examples/conservcontainer/index.html 1176015 > /trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js > 1176015 > > Diff: https://reviews.apache.org/r/2052/diff > > > Testing > ------- > > passed maven build. > > > Thanks, > > li > >
